Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move and fix Accessibility sections for HTML element pages #35658

Merged
merged 4 commits into from
Aug 31, 2024
Merged

Move and fix Accessibility sections for HTML element pages #35658

merged 4 commits into from
Aug 31, 2024

Conversation

mcaskill
Copy link
Contributor

@mcaskill mcaskill commented Aug 31, 2024 •
edited
Loading

Description

Various changes and fixes; does not change the content of the sections:

  • Fix EmbedLiveSample ID under Accessibility section for the HTML <abbr> element page.
  • Move and rename Accessibility section for the HTML <html> root element page.
  • Move and rename Accessibility section for the HTML <input> element page.

Motivation

Bring pages in line with template change from #33628, as agreed in github.com/orgs/mdn/discussions/430, and fix related issues.

Additional details

Full discussion thread: github.com/orgs/mdn/discussions/430

Related issues and pull requests

@mcaskill
Rename accessibility section in HTML input element page
d06db91
@mcaskill
Move and rename accessibility section for HTML root element page
9fcc93f
@mcaskill
Fix embed under accessibility section in HTML abbr element page
69fc87c 
In order to match the section heading. Previously only worked because the macro is located within the same section as the sample code.
@mcaskill mcaskill requested a review from a team as a code owner August 31, 2024 17:47
@mcaskill mcaskill requested review from estelle and removed request for a team August 31, 2024 17:47
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/s [PR only] 6-50 LoC changed labels Aug 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 31, 2024 •
edited
Loading

Preview URLs

External URLs (5)

URL: /en-US/docs/Web/HTML/Element/input
Title: <input>: The Input (Form Input) element

URL: /en-US/docs/Web/HTML/Element/html
Title: <html>: The HTML Document / Root element

(comment last updated: 2024-08-31 17:54:35)

@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Aug 31, 2024
Josh-Cena
Josh-Cena approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything else to fix before merging?

@mcaskill
Copy link
Contributor Author

@Josh-Cena The moving of the HTML <input> element's Accessibility section was the only missing change from this PR.

Thank you for the quick reply.

@Josh-Cena
Copy link
Member

Got it. Thanks

@Josh-Cena Josh-Cena merged commit 38cdfef into mdn:main Aug 31, 2024
8 checks passed
@mcaskill mcaskill deleted the fix-a11y-section-in-html-pages branch August 31, 2024 17:57
@sedlukha sedlukha mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-html

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcaskill @Josh-Cena